[theme-reviewers] Theme approval on Trac

[Edward Caissie]

This might be a good case study ...

The deprecated code appears to only be back to WP 2.8, and I agree many
themes start to fall apart under the (WP_DEBUG, true) condition, but it is
now part of the TDC to use WP_DEBUG when testing your theme.

Perhaps a cut-off date for "clean code" with minor issues to pass until
then; and,
A specified number of versions back on deprecated functions, maybe along the
lines of: at v3.1 no deprecated code prior to 2.8 or 2.9?


Cais.

On Tue, Jun 22, 2010 at 2:49 PM, Bavota San <c at bavotasan.com> wrote:

> Yup. With debug set to true the theme breaks. To tell you the truth, most
> themes do. If we want to make sure that developers are using 100% clean code
> with no deprecated functions we have to decide that and not let themes
> through that are not up to those standards.
>
> What do others think?
>
>
> c.bavota
> Web Programmer
> c at bavotasan.com
> http://bavotasan.com
> http://themes.bavotasan.com
>
>
> Become an Affiliate and earn 40% commission on sale referrals
> http://themes.bavotasan.com/affiliates
>
>
>
> On 2010-06-22, at 2:40 PM, Edward Caissie wrote:
>
> I was curious what parts of the theme code were deprecated and thought I
> would have a quick look.
>
> The theme looks and works quite well with WP_DEBUG set to false; but maybe
> a note to the author that there are many Notice statements being displayed
> with (WP_DEBUG, true), it also breaks the sidebar functionality completely
> for the tabbed section near the top.
>
>
> Cais.
>
> On Tue, Jun 22, 2010 at 2:06 PM, Bavota San <c at bavotasan.com> wrote:
>
>> I did this as well after I reviewed Mystique - 2.4.2 (
>> http://themes.trac.wordpress.org/ticket/19).
>>
>> c.bavota
>> Web Programmer
>> c at bavotasan.com
>> http://bavotasan.com
>> http://themes.bavotasan.com
>>
>>
>>
>>
>> Become an Affiliate and earn 40% commission on sale referrals
>> http://themes.bavotasan.com/affiliates
>>
>>
>>
>> On 2010-06-22, at 1:51 AM, Tom Lany wrote:
>>
>> > I just took a look at a theme (
>> http://themes.trac.wordpress.org/ticket/23) and marked it as approved,
>> and realized I shouldn't have done so, as it has not been added to the
>> directory, but I can't undo this.  Just thought I would post a message so
>> someone can approve this.
>> >
>> > Also, would it be possible to add a "Suggest Approval" category so that
>> users can mark themes for an administrator to approve without closing themes
>> as approved?
>> >
>> > Tom Lany
>> > _______________________________________________
>> > theme-reviewers mailing list
>> > theme-reviewers at lists.wordpress.org
>> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/mailman/private/theme-reviewers/attachments/20100622/ea320fa4/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 7435 bytes
Desc: not available
URL: <http://lists.wordpress.org/mailman/private/theme-reviewers/attachments/20100622/ea320fa4/attachment.png>