[theme-reviewers] Distilled Review

[Joseph Scott]

On Fri, Jun 11, 2010 at 12:44 PM, Tom Lany <mail at tomlany.net> wrote:
> Thanks for the note.
>
> I noticed that DB query, too, but didn't know how concerned I should be
> about those.  It would probably be best for the author to use the
> get_the_author function instead, as all they appear to be doing here is
> pulling an author name.  If they wanted to pull more information,
> http://codex.wordpress.org/Author_Templates might be a starting place.  I
> would agree that this query should be probably be removed, but we might want
> to get feedback on why it was included.
>
> I also noticed that ./lib/pngfix.js has an MIT license.  Is this acceptable?


That's fine that particular item, but I didn't see anything that
indicated licensing terms for the whole theme.  Perhaps it is time to
require a license.txt file for every theme, or a "License:" line as
part of the theme header block in style.css.


-- 
Joseph Scott
joseph at josephscott.org
http://josephscott.org/