[theme-reviewers] wp-themes: voidy - 1.3.1

[Joseph Scott]

Excellent feedback.  One thing to note is that the twentyten theme
depends on WP 3.0, which hasn't hit official release yet.  Supporting
new features is fine, but I wouldn't expect a theme to require them
until the version is actually released.  In the case of
the_author_meta() that isn't a problem since it's part of WP 2.9.2.


Please go ahead and pass that along to Niyaz PK <niyazpk at gmail.com>
(and the list again).

In addition, you get the first new theme review task :-)

Check out http://themes.svn.wordpress.org/wpt-magnitade-11/1.12 via
Subversion and post the review details to the list.  My hope is get
people comfortable with reviewing themes and then giving them direct
access to the review admin.



On Thu, Jun 10, 2010 at 2:04 AM, Safirul Alredha <zeo at unic.net.my> wrote:
> A quick look of voidy 1.4.0:
>
> - get_settings is deprecated, use get_option.
> - decide whether you want to make your theme translation-ready or not.
> Because some strings are wrap with __() or _e() function call and some
> don't.
> - use theme API.
>
> author.php
> - use the_author_meta() instead of $curauth var. See twentyten theme
> for example.
>
> comments.php
> - use comments_open() => ('open' == $post->comment_status)
> - !$user_ID => !is_user_logged_in()
> - <input type="hidden" name="redirect_to" value="<?php echo
> htmlspecialchars($_SERVER["REQUEST_URI"]); ?>" />? What is this for?
> - escape. For example: <?php echo $comment_author; ?> => <?php echo
> esc_attr($comment_author); ?>
>
> functions.php
> - use nonce in your form.
>
> header.php
> - automatic_feed_links(); for automatic output of feed link. Which is
> better than hard-coded feed link.
>
> footer.php
> - <?php bloginfo('siteurl'); ?>/wp-admin/ => <?php echo admin_url(); ?>
>
> index.php
> - <?php the_time('M') ?> <?php the_time('d') ?> <?php the_time('Y') ?>
> => <?php the_time('M d Y') ?> (also archive.php, search.php, 404.php)
>
> page-archives.php
> - wp_list_cats() is deprecated, use wp_list_categories()



-- 
Joseph Scott
joseph at josephscott.org
http://josephscott.org/