[buddypress-trac] [BuddyPress Trac] #6772: BuddyPress Embeds for activity, user profiles, groups

buddypress-trac noreply at wordpress.org
Thu Dec 17 17:57:45 UTC 2015

#6772: BuddyPress Embeds for activity, user profiles, groups
 Reporter:  imath                   |       Owner:
     Type:  idea                    |      Status:  new
 Priority:  normal                  |   Milestone:  2.5
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |

Comment (by imath):

 So i've just tested the patch.

 1/ there's something wrong with the way the embed link is build inside the
 sharing dialog box of the embed content :


 The part `?embed=true/` shouldn't be in the link.

 2/ I really think we should not try to display an embed in embed, because
 it's failing when we do an embed in embed in embed see:


 Because when you delete the first embedded activity its content not
 interprated (see image) keeps on being displayed into the activity that
 embed and embed another activity. (?!? becoming crazy with all these
 And because i remember a discussion about iframes, and i think one per
 embed is already the max contributors will be able to "tolerate" :)

 So i strongly suggest to take the `bp_activity_embed_excerpt()` road,
 displaying a link to the activity single view instead of the embed
 content: 'View full activity ->' (like i've was saying in my previous

 3/ Before it's lost in the great discussion we're having so far, why `bp-
 templates/bp-legacy/buddypress/embeds` and not `bp-templates/bp-
 legacy/buddypress/assets/embeds` ?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6772#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list