[buddypress-trac] [BuddyPress Trac] #6772: BuddyPress Embeds for activity, user profiles, groups

buddypress-trac noreply at wordpress.org
Thu Dec 17 10:20:28 UTC 2015

#6772: BuddyPress Embeds for activity, user profiles, groups
 Reporter:  imath                   |       Owner:
     Type:  idea                    |      Status:  new
 Priority:  normal                  |   Milestone:  2.5
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |

Comment (by imath):

 Hi r-a-y

 Just gave the patch a quick look, and it's looking pretty promising!!
 Thanks a lot for your great work on it.

 I promise i'll test it more in detailled asap.

 For the 3rd point i'm not sure we should try to display an embed media
 inside an embed activity. I think we should just use
 `bp_core_check_content_for_media_type()` to check if there's an embed
 content and display a link like 'View Full activity/Embed content'. I
 haven't tested but i can imagine cases like activity embedding a youtube
 video, being embed into another activity, being embed into a WordPress
 post etc... WordPress is using the excerpt of the post and i think it's
 removing embed content.

 About the share button, i agree with you. FYI I've been using the sharing
 dialog box generated by WordPress for my plugin because a profile is
 displayed once per parge, but i think in this case we shouldn't load this
 script for each activity item, but instead try to see if we can load it
 once, extend it and get the activity link/title within `data-` attributes
 of the button.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6772#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list