[buddypress-trac] [BuddyPress Trac] #6772: BuddyPress Embeds for activity, user profiles, groups

buddypress-trac noreply at wordpress.org
Thu Dec 17 22:13:21 UTC 2015

#6772: BuddyPress Embeds for activity, user profiles, groups
 Reporter:  imath                   |       Owner:
     Type:  idea                    |      Status:  new
 Priority:  normal                  |   Milestone:  2.5
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |

Comment (by r-a-y):

 Thanks for your feedback again, imath!

 `04.patch` does the following:

 - Fixes the URL in the `'WordPress Embed'` block
 - Replaced `BP_oEmbed_Component::$page_conditional_fn` property with the
 abstract `BP_oEmbed_Component::is_page()` method.  If a plugin has
 complicated page logic, it's easier to add that logic in this method.
 - Moves the embed template parts to `/assets/`.  I created a new function
 called `bp_get_asset_template_part()` to avoid having to add `assets/` to
 each `bp_get_template_part()` call.
 - Uses a text-based excerpt in the embed template.  I've taken some logic
 out of `bp_activity_create_summary()` and created a new function,

 As for:

 > I really think we should not try to display an embed in embed, because
 it's failing when we do an embed in embed in embed

 I think it is useful to display the first embed.  `04.patch` does this.
 I've changed the `bp_core_check_content_for_media_type()` function to
 `bp_core_extract_media_from_content()` to help do this.

 Let me know what you think.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6772#comment:14>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list