[buddypress-trac] [BuddyPress] #3242: blog comment spacing does not match activity stream spacing

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Wed May 25 19:45:43 UTC 2011


#3242: blog comment spacing does not match activity stream spacing
---------------------+-----------------
  Reporter:  DJPaul  |      Owner:
      Type:  defect  |     Status:  new
  Priority:  normal  |  Milestone:  1.3
 Component:  Theme   |    Version:  1.3
Resolution:          |   Keywords:
---------------------+-----------------

Comment (by Dennissmolek):

 @hnla

 if you apply the patch I dont think the margins would still be an issue.

 Second, the <LI> works as a separate container so I think its ok.
 I think comment-content is needed, when you introduce the children div as
 well as the avatar div, splitting out the actual content is useful.

 I agree about putting the content itself within another div. The activity
 stream is almost exactly the same and does this..


 I think another issue is the semantics we are using. For some reason the
 activity stream uses activity-header instead of activity-meta, then it
 uses activity-meta the same way blogs use comment-options.

 Wouldn't be an issue, but the threaded comments go back to the blog style
 format(assuming they used them as a template)

 I suggest we change the name of activity-header to activity meta,
 activity-meta to activity-options...

-- 
Ticket URL: <https://trac.buddypress.org/ticket/3242#comment:19>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list