[buddypress-trac] [BuddyPress] #3242: blog comment spacing does not match activity stream spacing

buddypress-trac at lists.automattic.com buddypress-trac at lists.automattic.com
Wed May 25 20:24:53 UTC 2011

#3242: blog comment spacing does not match activity stream spacing
  Reporter:  DJPaul  |      Owner:
      Type:  defect  |     Status:  new
  Priority:  normal  |  Milestone:  1.3
 Component:  Theme   |    Version:  1.3
Resolution:          |   Keywords:

Comment (by hnla):

 Think you're probably right, margins might not be an issue, before
 presentation can be addressed the final markup views need agreeing on then
 it's safe to look at any margin/padding issues.

 I don't think for one moment it would be safe removing elements for fear
 of breaking things, yet there is good case for that div vanishing, the li
 element is the parent container and comment-content is a somewhat
 unnecessary bit of semantics, yes we know it's the content what else could
 it be there's nothing else at a level above in that parent! This for me
 raises the issue of bp-default falling foul of that disease divitis, of
 over markingup layouts.

 I would agree with your name changes but also that what we appear to be
 highlighting is possibly a need for these various areas to be looked at
 and brought into line with each other also I would like the .comment-entry
 added even though it does counter my desire for leaner markup.

Ticket URL: <https://trac.buddypress.org/ticket/3242#comment:20>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list