[wp-trac] [WordPress Trac] #58962: Provide a way to load multiple specific options with a single database request

[WordPress Trac]

#58962: Provide a way to load multiple specific options with a single database
request
-------------------------------------------------+-------------------------
 Reporter:  flixos90                             |       Owner:  flixos90
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4
Component:  Options, Meta APIs                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests has-dev-    |     Focuses:
  note                                           |  performance
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 Hello all,

 @peterwilsoncc pinged me for another opinion.

 I'm all for consistency +1

 However, @flixos90 [comment:9 identifies a difference] with the functions
 in this PR versus the other internal (Core-only) priming functions:

 >That is different with the functions here which are primarily introduced
 for plugins to make use of them.

 The underscore `_` prefix is a common technique to further identify
 internal only usage, i.e. not for public usage.

 As these functions are (or also) for plugins to use, they are public, not
 private Core-only priming functions. IMO they should not be prefixed with
 `_`.

 Another concern I'd like to voice - the DevNote has been published. Could
 extenders have already modified their code to use the functions? If yes,
 consideration is needed for how to alert them to the rename changes to
 avoid potential fatal errors in their usages.

 cc @flixos90 @joemcgill @peterwilsoncc

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/58962#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform