[wp-trac] [WordPress Trac] #59591: Missing checks for pattern files trigger (invisible) PHP warnings

[WordPress Trac]

#59591: Missing checks for pattern files trigger (invisible) PHP warnings
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4
Component:  Themes                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch 2nd-       |     Focuses:
  opinion                                        |  performance
-------------------------------------------------+-------------------------

Comment (by afercia):

 > Also, please do not make this personal. I am very well aware of my
 involvement in this effort, and I do not gain anything from having
 development mode or this ticket in core.

 I didn't mean anything malicious. I did mean that, from a human
 perspective, I do understand very well how much everybody is 'emotionally'
 attached to their own code, because of the huge effort and dedication we
 all put in contributing to this project. Based on my experience, sometimes
 this emotional attachment may lead to decisions that aren't ideal. We all
 should make an effort to be ready to accept concerns and criticism even
 when we don't like it. Personally, I learned it the hard way.

 > there would still be other instances of cached theme files still in
 core. We need to have a holistic discussion and make a holistic decision
 on this topic

 I agree on this point. I also heard a similar caching mechanism is being
 worked on for templates, so that a holistic discussion makes totally
 sense. My concern is that tomorrow is WordPress RC 1 day and we're a bit
 too late to make sure caching won't introduce new problems for users.

 > We need to have a holistic discussion

 Starting a discussion the day before RC 1 is maybe a bit too late but fair
 enough, I will create a new ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59591#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform