[wp-trac] [WordPress Trac] #59591: Missing checks for pattern files trigger (invisible) PHP warnings

[WordPress Trac]

#59591: Missing checks for pattern files trigger (invisible) PHP warnings
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4
Component:  Themes                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch 2nd-       |     Focuses:
  opinion                                        |  performance
-------------------------------------------------+-------------------------

Comment (by spacedmonkey):

 The current solution, does not take into account the adding of new pattern
 files.

 I have put together a [https://github.com/WordPress/wordpress-
 develop/pull/5495 PR] that scales back the caching a little to add for the
 detection of new files being added.

 This PR replaces 50+ file_exists and with a simple glob function call,
 which maybe better for performance.

 Can you take a look @flixos90

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59591#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform