[wp-trac] [WordPress Trac] #59591: Missing checks for pattern files trigger (invisible) PHP warnings

WordPress Trac noreply at wordpress.org
Mon Oct 16 11:01:03 UTC 2023


#59591: Missing checks for pattern files trigger (invisible) PHP warnings
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  flixos90
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.4
Component:  Themes                               |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch 2nd-       |     Focuses:
  opinion                                        |  performance
-------------------------------------------------+-------------------------

Comment (by flixos90):

 @afercia I understand what 2nd opinion means. However, your concerns are
 based on the concept behind the development mode, which is not what this
 ticket is about. Also, please do not make this personal. I am very well
 aware of my involvement in this effort, and I do not gain anything from
 having development mode or this ticket in core.

 The reason I closed the ticket is that it's not the right place for
 discussing the concerns you raised. This ticket caches block pattern data,
 which comes from theme files. Even if this was reverted, there would still
 be other instances of cached theme files still in core. We need to have a
 holistic discussion and make a holistic decision on this topic - not
 handle it one way in one ticket and another way in another.

 I would encourage you to open a new ticket for that reason. I am not going
 to close this again, but please consider the above.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59591#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list