[wp-trac] [WordPress Trac] #64510: _wp_delete_all_temp_backups not accounting for direct filesystem access

[WordPress Trac]

#64510: _wp_delete_all_temp_backups not accounting for direct filesystem access
-------------------------------+------------------------------
 Reporter:  i4nd90             |       Owner:  (none)
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Upgrade/Install    |     Version:  trunk
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |     Focuses:
-------------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:   => reporter-feedback


Comment:

 Replying to [ticket:64510 i4nd90]:
 > If request_filesystem_credentials() evaluates that the type == 'direct',
 it return boolean of true, therefore the condition `! WP_Filesystem(
 $credentials ) ` is met

 Hi there, welcome to WordPress Trac! Thanks for the ticket.

 I could not reproduce the issue so far. In my testing,
 `request_filesystem_credentials()` does return `true` in this scenario,
 but then `WP_Filesystem( $credentials )` also returns `true` (as it should
 on success), and the negative condition is not met.

 If the condition is met on your install, that means there was an error
 somewhere in `WP_Filesystem()`, so some more investigation would be
 helpful here.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64510#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform