[wp-trac] [WordPress Trac] #64510: _wp_delete_all_temp_backups not accounting for direct filesystem access

[WordPress Trac]

#64510: _wp_delete_all_temp_backups not accounting for direct filesystem access
-----------------------------+-----------------------------
 Reporter:  i4nd90           |      Owner:  (none)
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  trunk
 Severity:  normal           |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 wp-includes/update.php:1156
 {{{#!php
 ob_start();
 $credentials = request_filesystem_credentials( '' );
 ob_end_clean();

 if ( false === $credentials || ! WP_Filesystem( $credentials ) ) {
         wp_trigger_error( __FUNCTION__, __( 'Could not access filesystem.'
 ) );
         return;
 }
 }}}

 If request_filesystem_credentials() evaluates that the type == 'direct',
 it return boolean of true, therefore the condition `! WP_Filesystem(
 $credentials ) ` is met and the upgrade-temp-backup dir never gets emptied

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/64510>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform