[wp-trac] [WordPress Trac] #39362: Checkbox control for 'Automatically add new top-level pages to this menu' not wrapped in checkbox customize control

[WordPress Trac]

#39362: Checkbox control for 'Automatically add new top-level pages to this menu'
not wrapped in checkbox customize control
-------------------------------+------------------------------
 Reporter:  dingo_d            |       Owner:  (none)
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Customize          |     Version:  4.7
 Severity:  normal             |  Resolution:
 Keywords:  2nd-opinion close  |     Focuses:
-------------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:  2nd-opinion => 2nd-opinion close


Comment:

 The `nav-menus` script uses the `.customize-control-checkbox input`
 selector (within a section) to show the current menu names for each
 location on [https://github.com/WordPress/wordpress-
 develop/blob/5930f083861dc48e1f4712720e62196e6cbc8793/src/js/_enqueues/wp/customize
 /nav-menus.js#L2970-L2975 line 2971]. When I added the `customize-control-
 checkbox` class to the same `<li>` as `customize-control-
 nav_menu_auto_add` and checked the "Automatically add new top-level pages"
 box, it did not create console errors. However, I might have missed a
 different problem with adding the class there.

 [35643] used three selectors for consistent styling of radio buttons and
 checkboxes, and I think that is what custom styles should use.
 {{{
 .customize-control-radio input,
 .customize-control-checkbox input,
 .customize-control-nav_menu_auto_add input {
 }}}
 The same changeset also used selectors like `.customize-control
 input[type="checkbox"] + label` for the `line-height` in widget settings
 on narrow screens, but [41817] moved that to the `br` element (and [45189]
 removed the unit).

 ----

 The `todo` reference was one of three related to #30741, and [41726]
 resolved those by eliminating the need for a `content` parameter.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39362#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform