[wp-trac] [WordPress Trac] #17133: Code Editor: Register ctrl + s event for plugin/theme editor

[WordPress Trac]

#17133: Code Editor: Register ctrl + s event for plugin/theme editor
-------------------------------------+-------------------------------------
 Reporter:  jcnetsys                 |       Owner:  westonruter
     Type:  enhancement              |      Status:  closed
 Priority:  normal                   |   Milestone:  7.0
Component:  Plugins                  |     Version:  3.1
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-ux-feedback has-     |     Focuses:  javascript,
  patch has-test-info commit         |  administration
-------------------------------------+-------------------------------------
Changes (by westonruter):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"61588" 61588]:
 {{{
 #!CommitTicketReference repository="" revision="61588"
 Code Editor: Allow saving with Ctrl/Cmd+S in Theme/Plugin Editors.

 * Keyboard shortcuts work when CodeMirror is not enabled (due to syntax
 highlighting not being enabled), and when the user is not focused inside
 the CodeMirror editor.
 * The autocomplete trigger is switched from `keyup` to `inputRead` to
 improve reliability, support IME composition, and prevent conflicts with
 modifier keys (e.g., releasing `Ctrl`/`Cmd` before `s` after a save).
 * A `updateErrorNotice` method is exposed on the code editor instance to
 ensure validation errors are displayed when a save via shortcut is
 attempted, preventing "silent" failures. Otherwise, the linting error
 notice is only shown when focus leaves the editor.
 * The form submission is modernized by replacing the deprecated jQuery
 `.submit()` shorthand with `.trigger( 'submit' )`.

 Developed in https://github.com/WordPress/wordpress-develop/pull/10851

 Props westonruter, Junaidkbr, evansolomon, desrosj, mukesh27, jonsurrell,
 spiraltee, chexee, andrewryno, tusharaddweb, gauri87, huzaifaalmesbah,
 ocean90, karmatosed, johnbillion, scribu, jcnetsys.
 Fixes #17133.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/17133#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform