[wp-trac] [WordPress Trac] #63704: Docs: Fix typo and mark unused parameter in deprecated functions

[WordPress Trac]

#63704: Docs: Fix typo and mark unused parameter in deprecated functions
--------------------------------------------+------------------------------
 Reporter:  bhaveshdesai                    |       Owner:  (none)
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  Awaiting Review
Component:  General                         |     Version:
 Severity:  minor                           |  Resolution:
 Keywords:  dev-feedback close 2nd-opinion  |     Focuses:  docs
--------------------------------------------+------------------------------
Changes (by sabernhardt):

 * keywords:  dev-feedback => dev-feedback close 2nd-opinion
 * focuses:  coding-standards => docs
 * severity:  normal => minor


Comment:

 I think I prefer not to make any of these revisions, but I made a patch
 with only the first.

 1. "Calculated" could be worth changing to "Calculates", but three
 commits—while `get_udims()` was still in use—did not fix that typo when
 they edited other parts of the same line. \\(either
 [https://core.trac.wordpress.org/changeset/8912/trunk/wp-
 admin/includes/image.php r8912],
 [https://core.trac.wordpress.org/changeset/9119/trunk/wp-
 admin/includes/image.php r9119], or
 [https://core.trac.wordpress.org/changeset/18632/trunk/wp-
 admin/includes/image.php r18632])
 2. `debug_fclose()` already identifies that the `$fp` parameter is unused.
    {{{
  * @param mixed $fp Unused.
    }}}
 3. Adding an extra space in the `str_replace` parameters is not a good
 idea in a deprecated function. If matching `'<img '` instead of `'<img'`
 somehow could prevent a problem, four (non-deprecated) functions in `wp-
 includes/media.php` use `'<img'` without the space.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63704#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform