[wp-trac] [WordPress Trac] #63268: PHPStan code quality improvements for 6.9

[WordPress Trac]

#63268: PHPStan code quality improvements for 6.9
----------------------------+-------------------------------
 Reporter:  justlevine      |       Owner:  SergeyBiryukov
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  6.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by SergeyBiryukov):

 In [changeset:"60459" 60459]:
 {{{
 #!CommitTicketReference repository="" revision="60459"
 Coding Standards: Remove extra check in
 `wp_get_theme_data_template_parts()`.

 The `false === $metadata` check would always be true, as a non-false value
 causes an early return right before. To clarify this behavior, the
 needless priming of `$metadata = false` was removed as well, as there is
 no scenario where it will not be immediately overwritten.

 Follow-up to [56385].

 Props justlevine.
 See #63268.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63268#comment:172>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform