[wp-trac] [WordPress Trac] #63268: PHPStan code quality improvements for 6.9

[WordPress Trac]

#63268: PHPStan code quality improvements for 6.9
----------------------------+-------------------------------
 Reporter:  justlevine      |       Owner:  SergeyBiryukov
     Type:  task (blessed)  |      Status:  accepted
 Priority:  normal          |   Milestone:  6.9
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by SergeyBiryukov):

 In [changeset:"60450" 60450]:
 {{{
 #!CommitTicketReference repository="" revision="60450"
 Coding Standards: Replace redundant check in
 `wpmu_validate_blog_signup()`.

 The `is_object()` check would always be true in the second part of the
 conditional. This commit adds an `instanceof WP_User` check instead before
 accessing the `user_login` property.

 Follow-up to [41963], [https://mu.trac.wordpress.org/changeset/550
 mu:550], [https://mu.trac.wordpress.org/changeset/1958 mu:1958], [12603].

 Props justlevine.
 See #63268.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/63268#comment:170>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform