[wp-trac] [WordPress Trac] #44958:   character in title generates a permalink (and slug) with space
WordPress Trac
noreply at wordpress.org
Tue Jun 25 23:04:21 UTC 2024
#44958:   character in title generates a permalink (and slug) with space
-------------------------------------------------+-------------------------
Reporter: ace2_heart | Owner: (none)
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 6.7
Component: Permalinks | Version: 4.8
Severity: normal | Resolution:
Keywords: needs-testing has-patch has- | Focuses:
testing-info has-screenshots needs-unit-tests |
-------------------------------------------------+-------------------------
Comment (by dmsnell):
@hellofromTonya we can open a new ticket for 6.7 if we need to, but I
don't understand why we are calling [https://github.com/WordPress
/wordpress-develop/pull/5466 PR #5466] an enhancement instead of a bug
fix.
The smaller patch here proposes fixing one very specific incarnation of a
broader bug, and unfortunately at the current time introduces more
breakage (and so I think it would be best to ensure that if we merge it,
we fix that remaining issue before doing so).
The goal of the alternative patch in the PR is to comprehensively solve
the category of defects that this reported issue is a manifestation of.
It's goal has been to maintain the same interface and intent of the
existing code, though I created `sluggify()` the new function mostly to
make it possible to examine the older and newer code at the same time
during review.
So I don't really care what goes on, but if we create a new ticket I feel
like it should still be a bug fix, since the core issue reported here is
that the slug generation does not adequately parse the inbound content and
therefore all of the replacement logic is fragile and prone to only work
in very specific cases. Do we classify a patch as a bug fix if it resolves
1 bug, but an enhancement if it resolves 1000?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44958#comment:39>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list