[wp-trac] [WordPress Trac] #61385: Revert using regex in block bindings HTML replacement logic

WordPress Trac noreply at wordpress.org
Thu Jun 13 08:56:03 UTC 2024


#61385: Revert using regex in block bindings HTML replacement logic
---------------------------------------------+-----------------------
 Reporter:  santosguillamot                  |       Owner:  audrasjb
     Type:  defect (bug)                     |      Status:  closed
 Priority:  high                             |   Milestone:  6.6
Component:  HTML API                         |     Version:  trunk
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch commit has-unit-tests  |     Focuses:
---------------------------------------------+-----------------------
Changes (by audrasjb):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58398" 58398]:
 {{{
 #!CommitTicketReference repository="" revision="58398"
 HTML API: Revert using regex in block bindings HTML replacement logic.

 This changeset reverts part of the changes made in [58298] to avoid using
 regex that can cause potential bugs. It is indeed safer to revert these
 changes for now and do the refactoring once the HTML API supports CSS
 selectors and provides a way to set inner content.

 It also adds a unit test to cover the regression experienced in
 https://github.com/WordPress/gutenberg/issues/62347.

 Follow-up to [58298].

 Props santosguillamot, gziolo.
 Fixes #61385.
 See #61351.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61385#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list