[wp-trac] [WordPress Trac] #61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on activation

[WordPress Trac]

#61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on
activation
-------------------------------------------------+-------------------------
 Reporter:  jorbin                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.6
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info 2nd-opinion                       |  administration
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 == (Re)Test Report - Page reload after activating a plugin with no
 redirect

 Retesting after fix for issue found in [#comment:31 this test report].

 Patch tested: [https://github.com/WordPress/wordpress-
 develop/pull/6732/commits/ae9b540c7c2166e43a6a87e8bd357d13dbfa6948 PR 6732
 as of this commit] which is the fix for the bug being retested.

 === Scenarios - Test Paths

 For plugins that do not have a redirect within them, the current page
 where the plugin gets activated should reload after activation.

 Where? Add Plugins `plugin-install.php` UI

 1. Search Results tab - when search for a plugin via the Search Plugins
 field
 2. Beta Testing tab
 3. Featured tab
 4. Popular tab
 5. Recommended tab
 6. Favorites tab

 === Steps to Test: Search Result tab

 1. Go to Plugins > Add Plugins UI, i.e. `wp-admin/plugin-install.php`.
 2. In the search field, type `core rollback`.
 3. In its card, install and activate it.
 4. After activation, what page is reloaded?

 ==== Expected Results
 - ✅ Should return to Add Plugins UI with the search results showing:
 {{{
 wp-admin/plugin-install.php?s=core%2520rollback&tab=search&type=term
 }}}

 === Steps to Test: Beta Testing tab

 1. Click on the Beta Testing tab (assuming you are already on the Plugins
 > Add Plugins UI from the last test).
 2. Install and activate one of the plugins, e.g. Performance Lab.
 3. After activation, what page is reloaded?

 ==== Expected Results
 - ✅ Should reload (return to) Add Plugins UI > Beta Testing tab:
 {{{
 wp-admin/plugin-install.php?tab=beta
 }}}

 === Steps to Test: Featured tab

 1. Click on the Featured tab (assuming you are already on the Plugins >
 Add Plugins UI from the previous test).
 2. Install and activate one of the plugins, e.g. Health Check &
 Troubleshooting.
 3. After activation, what page is reloaded?

 ==== Expected Results
 - ✅ Should reload (return to) Add Plugins UI > Featured tab:
 {{{
 wp-admin/plugin-install.php?tab=featured
 }}}

 === Steps to Test: Popular tab

 1. Click on the Popular tab (assuming you are already on the Plugins > Add
 Plugins UI from the previous test).
 2. Install and activate one of the plugins, e.g. Contact Form 7.
 3. After activation, what page is reloaded?

 ==== Expected Results
 - ✅ Should reload (return to) Add Plugins UI > Popular tab:
 {{{
 wp-admin/plugin-install.php?tab=popular
 }}}

 === Steps to Test: Recommended tab

 1. Click on the Recommended tab (assuming you are already on the Plugins >
 Add Plugins UI from the previous test).
 2. Install and activate one of the plugins, e.g. Health Check &
 Troubleshooting.
 3. After activation, what page is reloaded?

 ==== Expected Results
 - ✅ Should reload (return to) Add Plugins UI > Recommended tab:
 {{{
 wp-admin/plugin-install.php?tab=recommended
 }}}

 === Steps to Test: Favorites tab

 1. Click on the Favorites tab (assuming you are already on the Plugins >
 Add Plugins UI from the previous test).
 2. Type a WPORG username such as `johnbillion` and then press the Get
 Favorites button.
 3. Install and activate one of the plugins, e.g. Query Monitor.
 4. After activation, what page is reloaded?

 ==== Expected Results
 - ✅ Should reload (return to) Add Plugins UI > Favorites tab:
 {{{
 wp-admin/plugin-
 install.php?tab=favorites&user=johnbillion&_wpnonce=39d077365b
 }}}

 Note: The nonce will be different in your test.

 === Environment
 * OS: macOS
 * Web Server: nginx
 * PHP: 7.4
 * WordPress: 6.6 trunk with the patch applied
 * Browser: Firefox 126.0
 * Theme: default
 * Plugins: See test instructions (I used the examples)

 ==== Actual Results

 ✅ Yes, the page reloads and the URL is correct for all the test
 scenarios.

 == Summary

 [https://github.com/WordPress/wordpress-
 develop/pull/6732/commits/ae9b540c7c2166e43a6a87e8bd357d13dbfa6948 The
 fix] resolves [#comment:31 the issue].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61330#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform