[wp-trac] [WordPress Trac] #61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on activation

WordPress Trac noreply at wordpress.org
Mon Jun 10 22:07:15 UTC 2024


#61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on
activation
-------------------------------------------------+-------------------------
 Reporter:  jorbin                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.6
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info 2nd-opinion                       |  administration
-------------------------------------------------+-------------------------

Comment (by costdev):

 > @hellofromTonya doesn't reload the same page after activation.
 > Instead, the URL is `wp-admin/plugin-install.php?s=core+rollback` which
 is the Add Plugins UI with the search field populated with core rollback.
 Pressing enter repopulates the search results.

 I've pushed [https://github.com/WordPress/wordpress-
 develop/pull/6732/commits/ae9b540c7c2166e43a6a87e8bd357d13dbfa6948 a
 commit to the PR] which should resolve this.

 Further details from the commit message:
 > Without URL-encoding, only the first `?arg=value` is retained, and any
 `&argX=valueX` is lost. Wrapping `wp_get_referer()` in `urlencode()`
 preserves these additional query arguments.

 I had a call to `urlencode()` there previously, but I removed it to avoid
 unnecessary double-encoding. In this case, encoding is necessary.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61330#comment:33>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list