[wp-trac] [WordPress Trac] #61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on activation

[WordPress Trac]

#61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on
activation
-------------------------------------------------+-------------------------
 Reporter:  jorbin                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.6
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info 2nd-opinion                       |  administration
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 == Test Report for bbPress

 Patch tested: new approach for PR 6732 [https://github.com/WordPress
 /wordpress-
 develop/pull/6732/commits/bb52ff8ae1f842de9e30e9ab157e3ff69f626538 as of
 this commit]

 === Environment

 - OS: macOS
 - Web Server: nginx
 - PHP: 7.4
 - WordPress: 6.6 `trunk` with the patch applied
 - Browser: Firefox 126.0
 - Theme: default
 - Plugin: bbPress - v 2.6.9

 === Notes

 My workflow in these tests:

 I did not retest on 6.4.4 or 6.5.4, as I already did those baselines in
 [#comment:21 previous test report]. Started with 6.4.4:

 Tested 6.6 with the PR applied:
 1. Navigated to the Add Plugins UI.
 2. Typed the name of the plugin the search box.
 3. Install > Activate using the plugin's card.
 4. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to the Add Plugins UI screen.
 5. Clicked the Go Back again to return to the `plugins.php` screen.
 6. Deactivated the plugin.
 7. Activated the plugin.
 8. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to `plugins.php` screen.
 9. Deactivated the plugin.
 10. Clicked the "View details" click.
 11. Activated the plugin in the modal.
 12. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to `plugins.php` screen.
 13. Deactivated the plugin.
 14. Navigated to the Add Plugins UI.
 15. Searched again for the plugin.
 16. In the plugin's card, clicked the "View Details" click.
 17. In the modal, clicked the Activate button.
 18. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to Add Plugins UI screen.
 19. Clicked Go Back again to return to `plugins.php` screen.
 20. Deactivated and deleted the plugin.

 === Actual Results for Test 2: a plugin with autoredirect but no
 dependencies

 Testing Add Plugins UI plugin card:
 * ✅ After activation, bbPress redirected to its Welcome page.
 * ✅ In your browser, using its "Go back" arrow or button returns you (in
 one-click) to the Add Plugins UI.
 * ✅ Upon returning to the Add Plugins UI, the plugin's status shows
 Active.

 For the Add Plugins UI in the plugin's "More Details" modal:
 * ✅ After activation, bbPress redirected to its Welcome page.
 * ✅ In your browser, using its "Go back" arrow or button returns you (in
 one-click) to the Add Plugins UI.
 * ✅ Upon returning to the Add Plugins UI, the plugin's status shows
 Active in the card and modal.

 For the `plugins.php` table list, using `Activate` under the plugin
 listing:
 * ✅ After activation, bbPress redirected to its Welcome page.
 * ✅ In your browser, using its "Go back" arrow or button returns you (in
 one-click) to `plugins.php` table list.
 * ✅ Upon returning, the plugin's status shows Active in the "View
 details" modal and within the Add Plugins UI plugin card and its modal.

 For the `plugins.php` table list, using `Activate` in the plugin's "View
 details" modal:
 * ✅ After activation, bbPress redirected to its Welcome page.
 * ✅ In your browser, using its "Go back" arrow or button returns you (in
 one-click) to `plugins.php` table list.
 * ✅ Upon returning, the plugin's status shows Active in the "View
 details" modal and within the Add Plugins UI plugin card and its modal.

 == Summary

 ✅ The new adapted patch resolves the issue found with bbPress, i.e. for
 plugins hooking into `load-plugins.php` for their redirect.

 TODO:
 * Search for and test other plugins using this same approach.
 * Retest all plugins listed in my 2 previous test reports, i.e. to
 validate no impacts from the changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61330#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform