[wp-trac] [WordPress Trac] #61574: [PHP] Remove PHP < 7.2 code
WordPress Trac
noreply at wordpress.org
Sat Jul 6 21:07:29 UTC 2024
#61574: [PHP] Remove PHP < 7.2 code
---------------------------------------------+-----------------------------
Reporter: ayeshrajans | Owner: SergeyBiryukov
Type: enhancement | Status: reviewing
Priority: normal | Milestone: 6.7
Component: General | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit has-unit-tests | Focuses:
---------------------------------------------+-----------------------------
Comment (by jrf):
Replying to [comment:17 dmsnell]:
> Hi @SergeyBiryukov - it looks like a few of the changes in [58682]
remove comments that were left in the past to provide insight into how to
adapt the code once PHP minimum versions passed a certain milestone.
@dmsnell Please read the commit message - the two "hints" about improving
the code are not actionable, so those comments have no value.
Other than that, the other comments only provided historical context,
which is no longer relevant (and can still be seen in the commit history).
The actionable bits - like for `wp_parse_url()` - were already actioned
years ago. At the time, the docblock was not updated as the "new" minimum
PHP version at that time was 5.6, but by now those comments really aren't
relevant anymore.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/61574#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list