[wp-trac] [WordPress Trac] #61574: [PHP] Remove PHP < 7.2 code

WordPress Trac noreply at wordpress.org
Sat Jul 6 20:33:40 UTC 2024


#61574: [PHP] Remove PHP < 7.2 code
---------------------------------------------+-----------------------------
 Reporter:  ayeshrajans                      |       Owner:  SergeyBiryukov
     Type:  enhancement                      |      Status:  reviewing
 Priority:  normal                           |   Milestone:  6.7
Component:  General                          |     Version:  trunk
 Severity:  normal                           |  Resolution:
 Keywords:  has-patch commit has-unit-tests  |     Focuses:
---------------------------------------------+-----------------------------

Comment (by dmsnell):

 Hi @SergeyBiryukov - it looks like a few of the changes in [58682] remove
 comments that were left in the past to provide insight into how to adapt
 the code once PHP minimum versions passed a certain milestone.

 Now that those milestones have passed, would it make sense to apply the
 advice in the comments? I'm worried that in removing the comments without
 changing the code we're removing helpful context for someone who wants to
 improve the code quality and consistency in the future. Was it intentional
 to remove the guidance without changing the code?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61574#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list