[wp-trac] [WordPress Trac] #59329: Firefox gets "ReferenceError: Â is not defined" in unminified moxie.js

[WordPress Trac]

#59329: Firefox gets "ReferenceError: Â is not defined" in unminified moxie.js
-----------------------------------------+-------------------------
 Reporter:  kinggmobb                    |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  6.8
Component:  Upload                       |     Version:  4.9
 Severity:  minor                        |  Resolution:
 Keywords:  has-patch changes-requested  |     Focuses:  javascript
-----------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:13 desrosj]:
 > `plupload.js`
 [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/vendor/plupload/plupload.js#L23
 already has one], but doesn't explicitly say that the file is a de-facto
 fork.
 >
 > I looked at some libraries in a similar situation (both PHP and JS), but
 couldn't find one with a header to that effect.

 Ah, I meant adding a note to the headers that the file was modified for
 WP. Sorry didn't explain it well. But probably better to explain a little
 more and/or mention that it is forked and will be maintained by the WP
 developers.

 > It may be worth standardizing this and adding to all of our adopted
 libraries.

 Yes, good idea! Seems some of the de-facto forked libs/files like
 [https://github.com/WordPress/wordpress-
 develop/blob/trunk/src/js/_enqueues/vendor/twemoji.js#L309 twemoji.js]
 have some inline comments. Others like [https://github.com/WordPress
 /wordpress-develop/blob/trunk/src/js/_enqueues/vendor/thickbox/thickbox.js
 thickbox.js] don't have anything although I'm sure the original Thickbox
 JS was modified many times to make it work with newer jQuery, etc.
 (unbelievably it is from 2007, and still works?!).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59329#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform