[wp-trac] [WordPress Trac] #59329: Firefox gets "ReferenceError: Â is not defined" in unminified moxie.js

[WordPress Trac]

#59329: Firefox gets "ReferenceError: Â is not defined" in unminified moxie.js
-----------------------------------------+-------------------------
 Reporter:  kinggmobb                    |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  6.8
Component:  Upload                       |     Version:  4.9
 Severity:  minor                        |  Resolution:
 Keywords:  has-patch changes-requested  |     Focuses:  javascript
-----------------------------------------+-------------------------

Comment (by desrosj):

 Replying to [comment:11 azaozz]:
 > Think I remember having some problems with plugins when the version
 string of an external JS library was changed in a similar way (the plugin
 was expecting only digits and dots?). As this is a minor release perhaps
 better to "play it safe" and go with `1.3.5.1` perhaps? Also may be good
 to add another header to the file explaining that this file was
 modified/is a (de-facto) fork.
 >

 Ah! Yes, I like that better. Let's go with `1.3.5.1` and introduce a
 header. `plupload.js`
 [https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/vendor/plupload/plupload.js#L23
 already has one], but doesn't explicitly say that the file is a de-facto
 fork.

 I looked at some libraries in a similar situation (both PHP and JS), but
 couldn't find one with a header to that effect. It may be worth
 standardizing this and adding to all of our adopted libraries.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/59329#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform