[wp-trac] [WordPress Trac] #61381: Bulk update plugins no longer working when 1 Plugin failed to update

[WordPress Trac]

#61381: Bulk update plugins no longer working when 1 Plugin failed to update
-------------------------------------------------+-------------------------
 Reporter:  rickhaer                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Plugins                              |     Version:  6.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info has-screenshots     |     Focuses:
  has-patch needs-testing changes-requested      |
-------------------------------------------------+-------------------------
Changes (by ironprogrammer):

 * keywords:  has-testing-info has-screenshots has-patch needs-testing =>
     has-testing-info has-screenshots has-patch needs-testing changes-
     requested


Comment:

 @siliconforks, the proposed fix is nearly there! The updates continued
 after an error, but the admin notice for the failure isn't rendering as
 expected (Figure 1).

 If you're able to, I would recommend creating a PR in
 [https://github.com/WordPress/wordpress-develop wordpress-develop] to
 continue this work, as it will make collaboration and code review a bit
 easier going forward. (But to be clear, it's fine to submit .diffs if this
 is what works best for you.)

 == Test Report
 Patch tested:
 https://core.trac.wordpress.org/attachment/ticket/61381/61381.diff

 === Environment
 - Hardware: MacBook Pro Apple M1 Pro
 - OS: macOS 14.6.1
 - Browser: Safari 17.6
 - Server: nginx/1.27.0
 - PHP: 8.2.22
 - SQLite: 3.43.2
 - WordPress: 6.5
 - Theme: twentytwentythree v1.2
 - Active Plugins:
  - plugin-update-failure (test mu plugin to trigger Akismet update
 failure)
  - db.php (drop-in for SQLite)

 === Actual Results
 - ✅ During bulk update, after a plugin update failure, subsequent updates
 proceed successfully.
 - ❌ After a failed bulk update, the update failures admin notice does not
 display as expected. The notice is styled as "success" and does not
 contain the list of failed updates. (See comment:4 for expected example.)

 === Supplemental Artifacts
 ''Figure 1: Bulk update failure result with patch applied.''
   [[Image(https://cldup.com/hZI6QNxYvh-3000x3000.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61381#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform