[wp-trac] [WordPress Trac] #61381: Bulk update plugins no longer working when 1 Plugin failed to update

[WordPress Trac]

#61381: Bulk update plugins no longer working when 1 Plugin failed to update
-------------------------------------------------+-------------------------
 Reporter:  rickhaer                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Plugins                              |     Version:  6.5
 Severity:  normal                               |  Resolution:
 Keywords:  has-testing-info has-screenshots     |     Focuses:
  has-patch needs-testing                        |
-------------------------------------------------+-------------------------
Changes (by ironprogrammer):

 * keywords:   => has-testing-info has-screenshots has-patch needs-testing
 * version:  6.5.4 => 6.5


Comment:

 Welcome to Trac, and thank you for the report, @rickhaer!

 I can confirm this regression was introduced with WordPress 6.5. Thanks
 for looking into a fix, @siliconforks.

 == Reproduction Report

 === Reproduction Test Steps
 1. In WordPress 6.5+, install a previous version of at least two plugins.
 In 6.5, Akismet was already outdated at v5.2, and I used  `wp plugin
 install query-monitor --version=3.16.3` to install the previous version of
 [https://wordpress.org/plugins/query-monitor/ Query Monitor].
 2. Simulate a plugin update failure. I used an
 [https://gist.github.com/ironprogrammer/4e3826aeb1ef32c0e9dd696cf46637d7
 example mu-plugin to cause Akismet's update to fail] (Akismet was at the
 top of the plugin list).
 3. Trigger the plugin update failure by checking the box for each of these
 plugins, and selecting "Update" from the **Bulk actions** dropdown. Click
 **Apply**.
 4. 👀 Observe the update status for each of the checked plugins.

 === Expected Results
 - During a bulk plugin update, when an individual update fails, other
 plugin updates should continue to process.
 - When a bulk plugin update failure occurs, an admin notice should be
 displayed that highlights the failure(s).

 === Environment
 - Hardware: MacBook Pro Apple M1 Pro
 - OS: macOS 14.6.1
 - Browser: Safari 17.6
 - Server: nginx/1.27.0
 - PHP: 8.2.22
 - MySQL: 8.0.27
 - WordPress: 6.4.5, 6.5
 - Active Plugins:
  - plugin-update-failure (test mu plugin to cause Akismet's update to
 fail)
  - db.php (drop-in for SQLite)

 === Actual Results
 - ✅ **Reproduced:** The simulated plugin update failure caused subsequent
 plugin updates to halt.
 - ✅ **Reproduced:** The admin notice of failed updates is not visible.

 === Supplemental Artifacts
 ''Figure 1: Bulk update plugin failure in WP 6.4.5 and earlier.''
   [[Image(https://cldup.com/HT1kuqoGIg-3000x3000.png)]]

 ''🐞 Figure 2: Bulk update plugin failure in WP 6.5 and later.''
   [[Image(https://cldup.com/-YqZ5cT0aX.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61381#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform