[wp-trac] [WordPress Trac] #32282: WordPress image cropping is buggy

[WordPress Trac]

#32282: WordPress image cropping is buggy
------------------------------+-----------------------------
 Reporter:  Jossnaz           |       Owner:  joedolson
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  6.7
Component:  Media             |     Version:  4.2.2
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |     Focuses:  administration
------------------------------+-----------------------------
Changes (by joedolson):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"58915" 58915]:
 {{{
 #!CommitTicketReference repository="" revision="58915"
 Media: Fix admin image cropping calculations.

 The admin image editor crop function introduced rounding errors by using a
 scaled image to calculate values. Fix uses the image at 100% scale for
 calculations. Also avoid recalculating selection when the selection
 position is changed, and prevent incorrect values after scaling or
 restoration.

 Previously committed in [58456] and reverted in [58571]. The revert was
 due to a misattributed test failure.

 Props Jossnaz, johnillo, shailu25, rachelbaker, sudipatel007, joedolson,
 kevin940726 , andrewserong, hmbashar.
 Fixes #32282.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/32282#comment:45>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform