[wp-trac] [WordPress Trac] #43515: Twenty Seventeen: Two different function, which return same result
WordPress Trac
noreply at wordpress.org
Thu Apr 20 10:39:36 UTC 2023
#43515: Twenty Seventeen: Two different function, which return same result
---------------------------+---------------------
Reporter: mukesh27 | Owner: (none)
Type: enhancement | Status: new
Priority: low | Milestone: 6.3
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
---------------------------+---------------------
Changes (by SergeyBiryukov):
* keywords: => has-patch
Comment:
I think [attachment:"43515.1.patch"] looks good.
`twentyseventeen_is_frontpage()` is indeed more common and used in other
parts of the theme, while `twentyseventeen_is_static_front_page()` was
only ever used as a Customizer control callback.
Since the theme is no longer in active development, making the latter an
alias of the former would minimize the changes, otherwise I think we'd
have to update all instances of `twentyseventeen_is_frontpage()` in the
theme.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43515#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list