[wp-trac] [WordPress Trac] #43515: Twenty Seventeen: Two different function, which return same result
WordPress Trac
noreply at wordpress.org
Wed Apr 19 19:55:21 UTC 2023
#43515: Twenty Seventeen: Two different function, which return same result
---------------------------+---------------------
Reporter: mukesh27 | Owner: (none)
Type: enhancement | Status: new
Priority: low | Milestone: 6.3
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
---------------------------+---------------------
Changes (by audrasjb):
* keywords: dev-feedback =>
Comment:
Replying to [comment:7 sabernhardt]:
> I think the name `twentyseventeen_is_static_front_page()` is more self-
explanatory, but the other function is much more common and it was created
first.
>
> - [38833] imported the theme from GitHub with
`twentyseventeen_is_frontpage()`.
> - [38986] added `twentyseventeen_is_static_front_page()`, still before
version 1.0.
Given both were added before version 1.0, I think we can safely go with
`twentyseventeen_is_static_front_page()` which is indeed more self-
explanatory 👍
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43515#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list