[wp-trac] [WordPress Trac] #55650: PHP 8.0: improvements to allow for named parameters in WP 6.1

[WordPress Trac]

#55650: PHP 8.0: improvements to allow for named parameters in WP 6.1
--------------------------------------------+-----------------------------
 Reporter:  SergeyBiryukov                  |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  php80 has-patch has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53365" 53365]:
 {{{
 #!CommitTicketReference repository="" revision="53365"
 Code Modernization: Rename parameters to match native PHP functions in
 `wp-includes/compat.php`.

 This ensures that parameter names for PHP polyfills in WordPress core 100%
 match the native PHP parameter names. Otherwise using named parameters
 with those functions could cause fatal errors for installs where the
 polyfills kick in.

 This commit:
 * Renames the `$string` parameter to `$message` in `_()` polyfill.
 * Renames the `$str` parameter to `$string` in `mb_substr()` and
 `mb_strlen()` polyfills.
 * Renames the `$raw_output` parameter to `$binary` in `hash_hmac()`
 polyfill.
 * Renames the `$a` and `$b` parameters to `$known_string` and
 `$user_string` in `hash_equals()` polyfill.
 * Renames the `$var` parameter to `$value` in `is_countable()` and
 `is_iterable()` polyfills.
 * Renames the `$arr` parameter to `$array` in `array_key_first()` and
 `array_key_last()` polyfills.

 Follow-up to [52946], [52996], [52997], [52998], [53003], [53014],
 [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185],
 [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220],
 [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245],
 [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274],
 [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287],
 [53364].

 Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
 See #55650.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55650#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform