[wp-trac] [WordPress Trac] #55650: PHP 8.0: improvements to allow for named parameters in WP 6.1

WordPress Trac noreply at wordpress.org
Sat May 7 17:14:36 UTC 2022


#55650: PHP 8.0: improvements to allow for named parameters in WP 6.1
--------------------------------------------+-----------------------------
 Reporter:  SergeyBiryukov                  |       Owner:  SergeyBiryukov
     Type:  task (blessed)                  |      Status:  accepted
 Priority:  normal                          |   Milestone:  6.1
Component:  General                         |     Version:
 Severity:  normal                          |  Resolution:
 Keywords:  php80 has-patch has-unit-tests  |     Focuses:
--------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 In [changeset:"53364" 53364]:
 {{{
 #!CommitTicketReference repository="" revision="53364"
 Code Modernization: Rename parameters that use reserved keywords in `wp-
 admin/includes/template.php`.

 While using reserved PHP keywords as parameter name labels is allowed, in
 the context of function calls using named parameters in PHP 8.0+, this
 will easily lead to confusion. To avoid that, it is recommended not to use
 reserved keywords as function parameter names.

 This commit renames the `$parent` parameter to `$parent_page` in
 `parent_dropdown()`.

 Follow-up to [52946], [52996], [52997], [52998], [53003], [53014],
 [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185],
 [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220],
 [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245],
 [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274],
 [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287].

 Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
 See #55650.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55650#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list