[wp-trac] [WordPress Trac] #53370: Theme thumbnail/screenshot does not contain version string

WordPress Trac noreply at wordpress.org
Mon Mar 21 03:14:07 UTC 2022


#53370: Theme thumbnail/screenshot does not contain version string
-------------------------+-----------------------
 Reporter:  codente      |       Owner:  audrasjb
     Type:  enhancement  |      Status:  reopened
 Priority:  normal       |   Milestone:  6.0
Component:  Themes       |     Version:  5.7.2
 Severity:  minor        |  Resolution:
 Keywords:               |     Focuses:
-------------------------+-----------------------
Changes (by peterwilsoncc):

 * keywords:  has-patch =>


Comment:

 Do additional items need a version string or is this ticket ready to
 close?

 The only additional location I could find was the theme REST endpoint.

 https://github.com/WordPress/wordpress-
 develop/blob/8db1549c0f1af05fbb919ad2eeb7f7bff5a63da9/src/wp-includes
 /rest-api/endpoints/class-wp-rest-themes-controller.php#L265-L268

 If the version string is required everywhere, then including the hash in a
 backward compatible fashion in `WP_Themes::get_screenshot()` seems a more
 sensible approach.

 Each of the items `has-patch` applies to has been committed, so I am
 removing the keyword to reflect any future work that might be required.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53370#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list