[wp-trac] [WordPress Trac] #53974: Repeat Password field missing during installation

[WordPress Trac]

#53974: Repeat Password field missing during installation
-----------------------------+---------------------
 Reporter:  Eric3D           |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  6.0
Component:  Upgrade/Install  |     Version:  5.8
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:  ui
-----------------------------+---------------------

Comment (by walbo):

 Can reproduce the issue in safari.


 {{{
 [Warning] jQuery.Deferred exception: undefined is not an object
 (evaluating '$toggleButton.data') (2) (jquery.js, line 4050)
 "generatePassword at http://localhost:8889/wp-admin/js/user-
 profile.js?ver=6.0-alpha-52448-src:36:35
 bindPass1 at http://localhost:8889/wp-admin/js/user-
 profile.js?ver=6.0-alpha-52448-src:55:20
 bindPasswordForm at http://localhost:8889/wp-admin/js/user-
 profile.js?ver=6.0-alpha-52448-src:179:13
 @http://localhost:8889/wp-admin/js/user-
 profile.js?ver=6.0-alpha-52448-src:450:19
 mightThrow at http://localhost:8889/wp-
 includes/js/jquery/jquery.js?ver=3.6.0:3766:34
 @http://localhost:8889/wp-includes/js/jquery/jquery.js?ver=3.6.0:3834:22"
 undefined

 [Error] TypeError: undefined is not an object (evaluating
 '$toggleButton.data')
         (anonym funksjon) (jquery.js:4059)
 }}}

 In [https://github.com/WordPress/wordpress-
 develop/blob/14e20f72b568cfb5a85f57c77eaa538c17a5f302/src/js/_enqueues/admin
 /user-profile.js user-profile.js]:
 The issue seems to be that inside the function
 [https://github.com/WordPress/wordpress-
 develop/blob/14e20f72b568cfb5a85f57c77eaa538c17a5f302/src/js/_enqueues/admin
 /user-profile.js#L51 bindPass1()] the function
 [https://github.com/WordPress/wordpress-
 develop/blob/14e20f72b568cfb5a85f57c77eaa538c17a5f302/src/js/_enqueues/admin
 /user-profile.js#L55 generatePassword()] is runned, but `generatePassword`
 requires the [https://github.com/WordPress/wordpress-
 develop/blob/14e20f72b568cfb5a85f57c77eaa538c17a5f302/src/js/_enqueues/admin
 /user-profile.js#L36 $toggleButton] to be defined. This doesn't happend
 before after `bindPass1` is runned.

 Added a PR to bind the `$toggleButton` before `bindPass1` is runned.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53974#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform