[wp-trac] [WordPress Trac] #57306: External HTTP test failures
WordPress Trac
noreply at wordpress.org
Mon Dec 12 03:05:45 UTC 2022
#57306: External HTTP test failures
-------------------------------------------------+-------------------------
Reporter: SergeyBiryukov | Owner:
| SergeyBiryukov
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 6.2
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: dev-feedback has-patch has-unit- | Focuses:
tests |
-------------------------------------------------+-------------------------
Comment (by peterwilsoncc):
In the [https://core.trac.wordpress.org/ticket/57306 linked pull request]
* test moved to `tests/phpunit/tests/http/http.php`
* Largely the code above with a few coding standards fixes
* URLs changed to be more readable given the filter preempts the HTTP
request
* Added an assertion to ensure the preempting filter runs
* It now only covers the WP_Http method, it does not cover wp_remote_verb
function independently.
It looks like a few paths in the method are currently untested but I've
not concerned myself with that as the purpose of the PR is to get the
exiting test passing and validating the multiple location headers use-case
without needing an external HTTP request.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/57306#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list