[wp-trac] [WordPress Trac] #55443: Create WebP sub-sizes and use for output

[WordPress Trac]

#55443: Create WebP sub-sizes and use for output
-------------------------------------------------+-------------------------
 Reporter:  adamsilverstein                      |       Owner:
                                                 |  adamsilverstein
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  6.1
Component:  Media                                |     Version:  6.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests needs-dev-note        |     Focuses:
  needs-docs needs-user-docs needs-patch 2nd-    |  performance
  opinion needs-testing changes-requested        |
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 @costdev thanks for raising this, work to correct the unit tests is
 happening in https://github.com/WordPress/wordpress-develop/pull/3060

 > Just noting here, that these additional webp conversions appear to have
 been the leading cause of upload failures on the WordPress Photo Directory
 in recent weeks. See #meta6142 and tickets closed as duplicate of it.

 @dd32  Thanks for adding this important data point and the details on the
 ticket.

 Out of memory for the smaller images would be surprising, I wonder if this
 is exposing a bug - the memory should be reclaimed after each image resize
 (even if they happen as part of a long running process), but maybe that
 isn't how it currently works (the smaller core image sizes are processed
 last). I'll have to try some memory profiling to see if we can improve the
 processing and free up memory between resizes.

 > It hasn't affected every upload, only that of certain images.
 Potentially related to the $quality value being passed for webp requests
 (IIRC the default of 82 was optimized for jpeg?).

 We are investigating that setting in
 https://github.com/WordPress/performance/issues/7 and so far my research
 indicates the WebP level should actually match JPEGs, eg. we should lower
 it to 82. This might help a little but wouldn't solve your problem.

 > I've disabled the jpeg->webp conversion there [meta12023], temporarily
 at least, as we don't currently utilise the webp in the directory,
 however, this might be a sign that it might be worth considering only
 generating webp's for the resized images, rather than for the original
 file too.


 Thanks again for the feedback and for "dogfooding" trunk - this is exactly
 the type of data we need to make decisions around this feature. I was also
 happy to see your elegant fix disabling the feature. I assume that since
 adding the fix, reports of the issue have dissipated?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55443#comment:125>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform