[wp-trac] [WordPress Trac] #55443: Create WebP sub-sizes and use for output
WordPress Trac
noreply at wordpress.org
Fri Aug 19 04:37:01 UTC 2022
#55443: Create WebP sub-sizes and use for output
-------------------------------------------------+-------------------------
Reporter: adamsilverstein | Owner:
| adamsilverstein
Type: enhancement | Status: assigned
Priority: normal | Milestone: 6.1
Component: Media | Version: 6.0
Severity: normal | Resolution:
Keywords: has-unit-tests needs-dev-note | Focuses:
needs-docs needs-user-docs needs-patch 2nd- | performance
opinion needs-testing changes-requested |
-------------------------------------------------+-------------------------
Changes (by costdev):
* keywords:
has-unit-tests needs-dev-note needs-docs needs-user-docs needs-patch
2nd-opinion needs-testing
=>
has-unit-tests needs-dev-note needs-docs needs-user-docs needs-patch
2nd-opinion needs-testing changes-requested
Comment:
As an aside, please note:
- All tests that are prefixed with `it` need to be updated to use the
`test_` prefix instead. [https://make.wordpress.org/core/handbook/testing
/automated-testing/writing-phpunit-tests/#test-methods Ref].
- All data providers using the `provider_` prefix need to be updated to
use `data_` instead. [https://make.wordpress.org/core/handbook/testing
/automated-testing/writing-phpunit-tests/#repetitive-tests Ref 1].
[https://core.trac.wordpress.org/ticket/53119 Ref 2].
- All data providers using `yield` need to instead return an array of
arrays - named datasets with keys.
[https://make.wordpress.org/core/handbook/testing/automated-testing
/writing-phpunit-tests/#repetitive-tests Ref].
i.e.
{{{#!php
public function data_name_of_test_method() {
return array(
'the first dataset description' => array(
'the_first_argument_name' => 'value',
'the_second_argument_name' => 'value',
),
);
}
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55443#comment:124>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list