[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  early has-testing-info needs-patch   |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 @pbiron Thanks for the additional plugins to check Paul.

 I've tested with each of those plugins on the built version, I also threw
 Jetpack in to the mix as another big plugin.

 With [51815] reverted (`dcca93232b` on the git built version) all update
 and reactivate successfully.

 ----

 With the latest commit [51876] all fail to update correctly:

 * WooCommerce: Failure reported on upgrade screen due to fatal error
 * Yoast SEO: False success reported on upgrade screen (including
 reactivation) but actually fails to reactivate
 * MailPoet:  False success reported on upgrade screen (including
 reactivation) but actually fails to reactivate
 * Jetpack: Successfully reactivates but installation incomplete

 It appears Jetpack, Yoast SEO and MailPoet have error catching routines
 that gracefully manage errors if the plugin update is incomplete.

 Jetpack notice following update: "Your installation of Jetpack is
 incomplete. If you installed Jetpack from GitHub, please refer to this
 document to set up your development environment. Jetpack must have
 Composer dependencies installed and built via the build command."

 MailPoet notice upon attempting to reactivate manually: "MailPoet cannot
 start because it is missing core files. Please reinstall the plugin."

 Yoast SEO notice upon attempting to reactivate manually: "Activation
 failed: The Yoast SEO plugin installation is incomplete. Please refer to
 installation instructions."

 ----

 Doing timing checks with Yoast SEO, there's no significant difference
 between how long the requests take to complete with the reverted vs
 unreverted versions.

 When testing, there was an existing backup in the `upgrade/temp-
 backup/plugins/wordpress-seo` directory however, it appeared to be
 incomplete. The root directories files were not included. See
 [attachment:"Screen Shot 2021-09-30 at 10.34.40 am.png"].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:140>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform