[wp-trac] [WordPress Trac] #48244: script-loader.php Need to use _n() when more than one results are found
WordPress Trac
noreply at wordpress.org
Tue Sep 14 08:13:54 UTC 2021
#48244: script-loader.php Need to use _n() when more than one results are found
--------------------------------------+------------------------------
Reporter: tobifjellner | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Editor | Version: 4.5
Severity: normal | Resolution:
Keywords: good-first-bug has-patch | Focuses: javascript
--------------------------------------+------------------------------
Comment (by swissspidy):
Nice! We're getting there!
With the deprecation being done in `common.js`, `common` should be added
as a dependency to both scripts.
No need to add `wp-i18n` as a dependency.
Instead, use `$scripts->set_translations( 'wplink' );`, which will do this
automatically. `tags-suggest` already has this call, so all good there.
Nice find with r36806! Since that changeset is referencing a ticket with
milestone 4.5.0, that would be the correct version for the `@since`
annotation.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48244#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list