[wp-trac] [WordPress Trac] #48244: script-loader.php Need to use _n() when more than one results are found

[WordPress Trac]

#48244: script-loader.php Need to use _n() when more than one results are found
--------------------------------------+------------------------------
 Reporter:  tobifjellner              |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Editor                    |     Version:  4.5
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  javascript
--------------------------------------+------------------------------

Comment (by rsiddharth):

 @swissspidy, Thank you for reviewing the patch.

 I've:

  * Removed `uiAutocompleteL10n` from script-loader.php
  * Deprecated `window.uiAutocompleteL10n` using `deprecateL10nObject`

 Questions:

  * Is script-loader.php:1099 (in the patch) the right place to add `wp-
 i18n`?[[BR]]
    I see the `wplink` plugin used in `wp_tinymce_inline_scripts`.
 Wondering if[[BR]]
    `wp-i18n` needs to be loaded there somehow?

  * Are the `@since` and `@deprecated` version numbers correct for[[BR]]
    window.uiAutocompleteL10n?[[BR]]
    I guessed `@since` from https://core.trac.wordpress.org/changeset/36806

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48244#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform