[wp-trac] [WordPress Trac] #54166: Updating errors due to PHP timeouts

[WordPress Trac]

#54166: Updating errors due to PHP timeouts
-------------------------------------------------+-------------------------
 Reporter:  aristath                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early dev-feedback needs-  |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by afragen):

 Just for reference, if `rename()` fails the function reverts to
 `copy_dir()`, which was there previously. File systems not having a
 `rename(j` command should continue to function as they did previously.

 The previous flow always emptied the specific plugin folder in `wp-
 content/plugins/` that's why a failed update would leave an empty folder.
 The `$clear_destination` parameter is always true when updating.
 https://github.com/WordPress/wordpress-
 develop/blob/6367c01844e34dd372b999beb0e370f52d8c42d5/src/wp-
 admin/includes/class-plugin-upgrader.php#L222-L239

 I don't believe streams are ever utilized in the plugin update process.

 While Peter and I haven't yet been able to figure out the issue on his
 system using Vagrant and Chassis, I don't believe that reverting r51899
 will fix it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54166#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform