[wp-trac] [WordPress Trac] #54166: Updating errors due to PHP timeouts

[WordPress Trac]

#54166: Updating errors due to PHP timeouts
-------------------------------------------------+-------------------------
 Reporter:  aristath                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early dev-feedback needs-  |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Reopening this as I think r51899 will need to be reverted:

 * `rename()` should not be in `move_dir()` -- different file systems use
 different functions, eg `ftp_rename()`
 * If the destination exists, it is always overwritten. This seems
 problematic and there should really be an `$overwrite` parameter per the
 other functions
 * In `_wp_handle_upload()` it's noted that `rename()` fails on streams, so
 that may be problematic & streams handled differently ('may' is the key
 word, with the other issues I haven't researched this)

 When [https://wordpress.slack.com/archives/CULBN711P/p1633665399322900
 trying to debug this issue] with @afragen on Friday, I was testing with
 the pull request applied and still having the problem so I am not sure it
 fixes the reported issue completely either.

 ----

 Reading the code and doing some logging earlier today, I think something
 that runs asynchronously isn't been accounted for which is leading to the
 error.

 Installing/updating akismet (a very small plugin) was showing different
 contents within the working directory at several points within the
 procedure.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54166#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform