[wp-trac] [WordPress Trac] #54385: Fatal error uploading media on PHP8

[WordPress Trac]

#54385: Fatal error uploading media on PHP8
-------------------------------------------------+-------------------------
 Reporter:  stevegs                              |       Owner:
                                                 |  adamsilverstein
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.9
Component:  Media                                |     Version:  2.5
 Severity:  normal                               |  Resolution:
 Keywords:  php8 has-patch needs-dev-note has-   |     Focuses:
  unit-tests                                     |
-------------------------------------------------+-------------------------

Comment (by adamsilverstein):

 Thanks for the feedback and new patches @TobiasBg
 . I'll incorporate this feedback/changes in an upcoming patch.

 After reviewing the values that are passed to the function, I have decided
 to restore the behavior that returns a string, this is what is expected by
 the calls to it, see https://github.com/WordPress/wordpress-
 develop/pull/1841/files#r752314252

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54385#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform