[wp-trac] [WordPress Trac] #54385: Fatal error uploading media on PHP8

[WordPress Trac]

#54385: Fatal error uploading media on PHP8
-------------------------------------------------+-------------------------
 Reporter:  stevegs                              |       Owner:
                                                 |  adamsilverstein
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.9
Component:  Media                                |     Version:  2.5
 Severity:  normal                               |  Resolution:
 Keywords:  php8 has-patch needs-dev-note has-   |     Focuses:
  unit-tests                                     |
-------------------------------------------------+-------------------------

Comment (by TobiasBg):

 Replying to [comment:27 stevegs]:
 > `str_contains()` is new in PHP8.  Not everyone has access to PHP8.

 That's correct, and that's why WordPress 5.9 will ship with its own copy
 of `str_contains()`, thanks to the recent code change [52039] :-) So
 starting with WP 5.9, for which the fix of this ticket is aimed for, it's
 perfectly save to use `str_contains()` even if someone uses it on PHP <
 8.0.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54385#comment:28>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform