[wp-trac] [WordPress Trac] #54410: GH Actions: Consider revising the Coding Standards actions to only scan modified files.

WordPress Trac noreply at wordpress.org
Tue Nov 16 14:39:23 UTC 2021


#54410: GH Actions: Consider revising the Coding Standards actions to only scan
modified files.
------------------------------+------------------------------
 Reporter:  costdev           |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  close             |     Focuses:
------------------------------+------------------------------
Changes (by desrosj):

 * keywords:   => close


Comment:

 #49783 has been closed as fixed. This will significantly improve the
 performance of the `phpcs` and `phpcompat` commands (by 95%+). So
 performance is no longer a primary benefit of this suggested change.

 The more I think about this, the more I lean towards `wontfix`. While it
 does happen occasionally, [https://make.wordpress.org/core/handbook/best-
 practices/commit-messages/#other-tips-for-committers committers are told
 to run the necessary CS checks prior to committing, and to monitor all CI
 builds for their commits].

 I don't like enforcing GH pull requests because everyone is free to use
 whichever workflow they like.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54410#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list