[wp-trac] [WordPress Trac] #42979: Draw "dismiss" icon in upload errors in the error div, not after the action title

[WordPress Trac]

#42979: Draw "dismiss" icon in upload errors in the error div, not after the action
title
-------------------------------------+-------------------------------------
 Reporter:  ComputerGuru             |       Owner:  joedolson
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.9
Component:  Media                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, accessibility,
  needs-design-feedback              |  administration
-------------------------------------+-------------------------------------

Comment (by ComputerGuru):

 Thanks for revisiting this bug and for putting in the work to clean up the
 UX here! Please keep in mind part of the original reason for filing: the
 proximity of the "uploading" text with the errors made it look like the
 errors were associated with the current upload.

 The biggest and clearest fix is of course moving the dismiss icon away
 from the "Uploading" text - anything else is just icing on the cake.
 Changing it (as rendered) to below the errors with "dismiss errors" is a
 colossal improvement - thank you.

 If there were some way to encode temporal proximity into the display, that
 would also help. Merely increasing the distance between "Uploading" and
 the errors is one way, adding a subtle divider is another. Or putting some
 sort of hint text "previous errors" or something of that nature to make it
 clear that the errors shown are not associated with the current action
 ("Uploading") because the way the text is formatted it still looks like
 "Uploading" is a heading for the error divs that follow, making it seem at
 first glance that the errors are associated with the very much current
 "Uploading" text when they are old (and stale).

 This is a little complicated by the multiple ways these errors can
 present: the first is where a single file is uploaded at a time and the
 error is from a previous upload, the second is where multiple files are
 being uploaded in one go and the errors are "streaming" in tandem with the
 upload (one or more files failing as they are uploaded and handled by the
 server).

 If we accept that in a one-at-a-time situation the user has almost
 certainly seen the error before re-attempting the upload of what may be
 the same file, I think it makes the most sense to clear the errors
 automatically (or fade them out, at least) when a new upload is initiated.
 For the multiple file upload situation, the current UX (short of multiple
 dismiss icons) is actually the most correct as it (correctly) draws a
 connection between the current operation (upload of multiple files) with
 the errors that were occuring during that time.

 I guess in all cases clearing existing errors (or fading them out or
 adding a significant whitespace above them perhaps with a title like
 "upload of n files") *so long as there is no upload still in progress*
 when a user starts a new upload would make the most sense, for both the
 one-at-a-time and multiple-at-once scenarios?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42979#comment:31>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform