[wp-trac] [WordPress Trac] #54229: Make dashboard widget control submit text filterable or change to "Save changes"

[WordPress Trac]

#54229: Make dashboard widget control submit text filterable or change to "Save
changes"
-------------------------------------------+----------------------
 Reporter:  zodiac1978                     |       Owner:  (none)
     Type:  enhancement                    |      Status:  new
 Priority:  normal                         |   Milestone:  5.9
Component:  Administration                 |     Version:
 Severity:  normal                         |  Resolution:
 Keywords:  reporter-feedback needs-patch  |     Focuses:  ui-copy
-------------------------------------------+----------------------
Changes (by hellofromTonya):

 * keywords:  has-patch commit => reporter-feedback needs-patch


Comment:

 Removing `commit` keyword as [attachment:"54229.1.diff"] does not address
 the 3 instances in Core.

 Also needs consensus to agree on changing the `submit_button` text from
 `Submit` to
 `Save Changes` vs making the `submit_button`'s text filterable.

 One way to make it filterable is to add a filter to `get_submit_button()`
 to filter the `$text`. However, in doing so, all submit buttons run
 through the filter, not just the ones mentioned in this ticket. I wonder:
 What value does the filter provide? Is it valuable for many folks?

 @zodiac1978 @knutsp What do you think? Is there enough value in changing
 the button's text? If yes, is `Save Changes` the correct text for each of
 these instances?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54229#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform